Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: webkit/browser/appcache/appcache_storage_impl_unittest.cc

Issue 164933002: Expose details for appcache error events [Chromium] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix merge glitch, complete a rename Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/browser/appcache/appcache_storage_impl.cc ('k') | webkit/browser/appcache/appcache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/browser/appcache/appcache_storage_impl_unittest.cc
diff --git a/webkit/browser/appcache/appcache_storage_impl_unittest.cc b/webkit/browser/appcache/appcache_storage_impl_unittest.cc
index 8a4d5d7de457497f177720555d553a35069a2c4c..0e364f51a16b020dfc59e6c0680e1d5e34d003eb 100644
--- a/webkit/browser/appcache/appcache_storage_impl_unittest.cc
+++ b/webkit/browser/appcache/appcache_storage_impl_unittest.cc
@@ -207,7 +207,8 @@ class AppCacheStorageImplTest : public testing::Test {
}
virtual void OnGroupMadeObsolete(AppCacheGroup* group,
- bool success) OVERRIDE {
+ bool success,
+ int response_code) OVERRIDE {
obsoleted_group_ = group;
obsoleted_success_ = success;
test_->ScheduleNextTask();
@@ -820,7 +821,7 @@ class AppCacheStorageImplTest : public testing::Test {
EXPECT_TRUE(database()->InsertOnlineWhiteList(&online_whitelist_record));
// Conduct the test.
- storage()->MakeGroupObsolete(group_.get(), delegate());
+ storage()->MakeGroupObsolete(group_.get(), delegate(), 0);
EXPECT_FALSE(group_->is_obsolete());
}
@@ -1607,7 +1608,8 @@ class AppCacheStorageImplTest : public testing::Test {
const GURL& url,
int num_total, int num_complete) OVERRIDE {}
virtual void OnErrorEventRaised(const std::vector<int>& host_ids,
- const std::string& message) OVERRIDE {
+ const appcache::ErrorDetails& details)
+ OVERRIDE {
error_event_was_raised_ = true;
}
virtual void OnLogMessage(int host_id, LogLevel log_level,
« no previous file with comments | « webkit/browser/appcache/appcache_storage_impl.cc ('k') | webkit/browser/appcache/appcache_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698