Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: webkit/browser/appcache/appcache_service.cc

Issue 164933002: Expose details for appcache error events [Chromium] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix merge glitch, complete a rename Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/browser/appcache/appcache_service.cc
diff --git a/webkit/browser/appcache/appcache_service.cc b/webkit/browser/appcache/appcache_service.cc
index 575355a599fd8b116dca91a531314a6f22544747..f3305199dc454d13864cf059a469c027b8fe56b3 100644
--- a/webkit/browser/appcache/appcache_service.cc
+++ b/webkit/browser/appcache/appcache_service.cc
@@ -143,8 +143,9 @@ class AppCacheService::DeleteHelper : public AsyncHelper {
// AppCacheStorage::Delegate implementation.
virtual void OnGroupLoaded(
appcache::AppCacheGroup* group, const GURL& manifest_url) OVERRIDE;
- virtual void OnGroupMadeObsolete(
- appcache::AppCacheGroup* group, bool success) OVERRIDE;
+ virtual void OnGroupMadeObsolete(appcache::AppCacheGroup* group,
+ bool success,
+ int response_code) OVERRIDE;
GURL manifest_url_;
DISALLOW_COPY_AND_ASSIGN(DeleteHelper);
@@ -155,7 +156,7 @@ void AppCacheService::DeleteHelper::OnGroupLoaded(
if (group) {
group->set_being_deleted(true);
group->CancelUpdate();
- service_->storage()->MakeGroupObsolete(group, this);
+ service_->storage()->MakeGroupObsolete(group, this, 0);
} else {
CallCallback(net::ERR_FAILED);
delete this;
@@ -163,7 +164,9 @@ void AppCacheService::DeleteHelper::OnGroupLoaded(
}
void AppCacheService::DeleteHelper::OnGroupMadeObsolete(
- appcache::AppCacheGroup* group, bool success) {
+ appcache::AppCacheGroup* group,
+ bool success,
+ int response_code) {
CallCallback(success ? net::OK : net::ERR_FAILED);
delete this;
}
@@ -189,8 +192,9 @@ class AppCacheService::DeleteOriginHelper : public AsyncHelper {
virtual void OnAllInfo(AppCacheInfoCollection* collection) OVERRIDE;
virtual void OnGroupLoaded(
appcache::AppCacheGroup* group, const GURL& manifest_url) OVERRIDE;
- virtual void OnGroupMadeObsolete(
- appcache::AppCacheGroup* group, bool success) OVERRIDE;
+ virtual void OnGroupMadeObsolete(appcache::AppCacheGroup* group,
+ bool success,
+ int response_code) OVERRIDE;
void CacheCompleted(bool success);
@@ -236,14 +240,16 @@ void AppCacheService::DeleteOriginHelper::OnGroupLoaded(
if (group) {
group->set_being_deleted(true);
group->CancelUpdate();
- service_->storage()->MakeGroupObsolete(group, this);
+ service_->storage()->MakeGroupObsolete(group, this, 0);
} else {
CacheCompleted(false);
}
}
void AppCacheService::DeleteOriginHelper::OnGroupMadeObsolete(
- appcache::AppCacheGroup* group, bool success) {
+ appcache::AppCacheGroup* group,
+ bool success,
+ int response_code) {
CacheCompleted(success);
}
« no previous file with comments | « webkit/browser/appcache/appcache_request_handler_unittest.cc ('k') | webkit/browser/appcache/appcache_storage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698