webkit/browser/appcache/appcache_host.cc - Issue 164933002: Expose details for appcache error events [Chromium]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/browser/appcache/appcache_host.cc

Issue 164933002: Expose details for appcache error events [Chromium] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Restore failed_resource_url Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/browser/appcache/appcache_host.cc

diff --git a/webkit/browser/appcache/appcache_host.cc b/webkit/browser/appcache/appcache_host.cc

index 598b100e7a4d9b22a8f847568ad129f3349e865d..b4b4222ce3dda6dadc1cb677351c8cec680afe29 100644

--- a/webkit/browser/appcache/appcache_host.cc

+++ b/webkit/browser/appcache/appcache_host.cc

@@ -116,7 +116,12 @@ void AppCacheHost::SelectCache(const GURL& document_url,

std::vector<int> host_ids(1, host_id_);

frontend_->OnEventRaised(host_ids, CHECKING_EVENT);

frontend_->OnErrorEventRaised(

- host_ids, "Cache creation was blocked by the content policy");

+ host_ids,

+ ErrorDetails("Cache creation was blocked by the content policy",

+ POLICY_ERROR,

+ GURL(),

+ 0,

+ false /*is_cross_origin*/));

frontend_->OnContentBlocked(host_id_, manifest_url);

return;

}