Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: webkit/browser/appcache/appcache_update_job.h

Issue 164933002: Expose details for appcache error events [Chromium] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't leak details cross-origin Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/browser/appcache/appcache_update_job.h
diff --git a/webkit/browser/appcache/appcache_update_job.h b/webkit/browser/appcache/appcache_update_job.h
index 3207fad34e98b9399f8b183bbe4502ece9f86ac1..806a03a7f9c99ff4380061810290062f70bf473b 100644
--- a/webkit/browser/appcache/appcache_update_job.h
+++ b/webkit/browser/appcache/appcache_update_job.h
@@ -126,6 +126,7 @@ class WEBKIT_STORAGE_BROWSER_EXPORT AppCacheUpdateJob
existing_entry_ = entry;
}
ResultType result() const { return result_; }
+ int canceled_response_code() const { return canceled_response_code_; }
private:
// URLRequest::Delegate overrides
@@ -153,6 +154,7 @@ class WEBKIT_STORAGE_BROWSER_EXPORT AppCacheUpdateJob
scoped_refptr<net::HttpResponseHeaders> existing_response_headers_;
std::string manifest_data_;
ResultType result_;
+ int canceled_response_code_;
scoped_ptr<AppCacheResponseWriter> response_writer_;
}; // class URLFetcher
@@ -165,7 +167,9 @@ class WEBKIT_STORAGE_BROWSER_EXPORT AppCacheUpdateJob
AppCache* newest_cache,
bool success,
bool would_exceed_quota) OVERRIDE;
- virtual void OnGroupMadeObsolete(AppCacheGroup* group, bool success) OVERRIDE;
+ virtual void OnGroupMadeObsolete(AppCacheGroup* group,
+ bool success,
+ int response_code) OVERRIDE;
// Methods for AppCacheHost::Observer.
virtual void OnCacheSelectionComplete(AppCacheHost* host) OVERRIDE {} // N/A
@@ -175,7 +179,7 @@ class WEBKIT_STORAGE_BROWSER_EXPORT AppCacheUpdateJob
virtual void OnServiceReinitialized(
AppCacheStorageReference* old_storage) OVERRIDE;
- void HandleCacheFailure(const std::string& error_message, ResultType result);
+ void HandleCacheFailure(const ErrorDetails& details, ResultType result);
void FetchManifest(bool is_first_fetch);
void HandleManifestFetchCompleted(URLFetcher* fetcher);
@@ -194,7 +198,7 @@ class WEBKIT_STORAGE_BROWSER_EXPORT AppCacheUpdateJob
void NotifyAllAssociatedHosts(EventID event_id);
void NotifyAllProgress(const GURL& url);
void NotifyAllFinalProgress();
- void NotifyAllError(const std::string& error_message);
+ void NotifyAllError(const ErrorDetails& detals);
void AddAllAssociatedHostsToNotifier(HostNotifier* notifier);
// Checks if manifest is byte for byte identical with the manifest
@@ -221,7 +225,7 @@ class WEBKIT_STORAGE_BROWSER_EXPORT AppCacheUpdateJob
void AddMasterEntryToFetchList(AppCacheHost* host, const GURL& url,
bool is_new);
void FetchMasterEntries();
- void CancelAllMasterEntryFetches(const std::string& error_message);
+ void CancelAllMasterEntryFetches(const ErrorDetails& details);
// Asynchronously loads the entry from the newest complete cache if the
// HTTP caching semantics allow.

Powered by Google App Engine
This is Rietveld 408576698