Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: webkit/browser/appcache/appcache_storage.h

Issue 164933002: Expose details for appcache error events [Chromium] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't leak details cross-origin Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/browser/appcache/appcache_storage.h
diff --git a/webkit/browser/appcache/appcache_storage.h b/webkit/browser/appcache/appcache_storage.h
index b7a696f43192cef3b6ed6b75b543814e1550a767..a6bdd0e52f03f90e1c38386c6f6c486fedf14cc5 100644
--- a/webkit/browser/appcache/appcache_storage.h
+++ b/webkit/browser/appcache/appcache_storage.h
@@ -52,7 +52,9 @@ class WEBKIT_STORAGE_BROWSER_EXPORT AppCacheStorage {
bool would_exceed_quota) {}
// If the operation fails, success will be false.
- virtual void OnGroupMadeObsolete(AppCacheGroup* group, bool success) {}
+ virtual void OnGroupMadeObsolete(AppCacheGroup* group,
+ bool success,
+ int response_code) {}
// If a load fails the 'response_info' will be NULL.
virtual void OnResponseInfoLoaded(
@@ -140,8 +142,9 @@ class WEBKIT_STORAGE_BROWSER_EXPORT AppCacheStorage {
// Schedules a task to update persistent storage and doom the group and all
// related caches and responses for deletion. Upon completion the in-memory
// instance is marked as obsolete and the delegate callback is called.
- virtual void MakeGroupObsolete(
- AppCacheGroup* group, Delegate* delegate) = 0;
+ virtual void MakeGroupObsolete(AppCacheGroup* group,
+ Delegate* delegate,
+ int response_code) = 0;
// Cancels all pending callbacks for the delegate. The delegate callbacks
// will not be invoked after, however any scheduled operations will still

Powered by Google App Engine
This is Rietveld 408576698