Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webkit/browser/appcache/appcache_host.cc

Issue 164933002: Expose details for appcache error events [Chromium] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't leak details cross-origin Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/child/appcache/web_application_cache_host_impl.cc ('K') | « webkit/browser/appcache/appcache_group_unittest.cc ('k') | webkit/browser/appcache/appcache_host_unittest.cc » ('j') | webkit/browser/appcache/appcache_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/browser/appcache/appcache_host.cc
diff --git a/webkit/browser/appcache/appcache_host.cc b/webkit/browser/appcache/appcache_host.cc
index 598b100e7a4d9b22a8f847568ad129f3349e865d..b4b4222ce3dda6dadc1cb677351c8cec680afe29 100644
--- a/webkit/browser/appcache/appcache_host.cc
+++ b/webkit/browser/appcache/appcache_host.cc
@@ -116,7 +116,12 @@ void AppCacheHost::SelectCache(const GURL& document_url,
std::vector<int> host_ids(1, host_id_);
frontend_->OnEventRaised(host_ids, CHECKING_EVENT);
frontend_->OnErrorEventRaised(
- host_ids, "Cache creation was blocked by the content policy");
+ host_ids,
+ ErrorDetails("Cache creation was blocked by the content policy",
+ POLICY_ERROR,
+ GURL(),
+ 0,
+ false /*is_cross_origin*/));
frontend_->OnContentBlocked(host_id_, manifest_url);
return;
}
« content/child/appcache/web_application_cache_host_impl.cc ('K') | « webkit/browser/appcache/appcache_group_unittest.cc ('k') | webkit/browser/appcache/appcache_host_unittest.cc » ('j') | webkit/browser/appcache/appcache_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698