content/browser/appcache/appcache_frontend_proxy.cc - Issue 164933002: Expose details for appcache error events [Chromium]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_frontend_proxy.cc

Issue 164933002: Expose details for appcache error events [Chromium] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Don't leak details cross-origin Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/appcache/appcache_frontend_proxy.cc

diff --git a/content/browser/appcache/appcache_frontend_proxy.cc b/content/browser/appcache/appcache_frontend_proxy.cc

index 0ef1e32b1b8ad7a1b94ea16c2fd785fc40b545d9..826dd84cae29e213c60818de05063d0b406f1f09 100644

--- a/content/browser/appcache/appcache_frontend_proxy.cc

+++ b/content/browser/appcache/appcache_frontend_proxy.cc

@@ -37,9 +37,8 @@ void AppCacheFrontendProxy::OnProgressEventRaised(

void AppCacheFrontendProxy::OnErrorEventRaised(

const std::vector<int>& host_ids,

- const std::string& message) {

- sender_->Send(new AppCacheMsg_ErrorEventRaised(

- host_ids, message));

+ const appcache::ErrorDetails& details) {

+ sender_->Send(new AppCacheMsg_ErrorEventRaised(host_ids, details));

}

void AppCacheFrontendProxy::OnLogMessage(int host_id,