Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1649283002: Expand zero-area target elements when computing intersections. (Closed)

Created:
4 years, 10 months ago by szager1
Modified:
4 years, 10 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand zero-area target elements when computing intersections. Based on spec discussion: https://github.com/WICG/IntersectionObserver/issues/69 BUG=540528 R=ojan@chromium.org,esprehn@chromium.org Committed: https://crrev.com/713261869cc5445c5a50c1e9187de53e440add6d Cr-Commit-Position: refs/heads/master@{#373035}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
A + third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target.html View 3 chunks +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target-expected.txt View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObservation.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
szager1
4 years, 10 months ago (2016-01-31 06:26:06 UTC) #1
ojan
lgtm for now. When chatting with apple, they wanted this to be revisited given the ...
4 years, 10 months ago (2016-02-02 06:15:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1649283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1649283002/1
4 years, 10 months ago (2016-02-02 17:58:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 21:12:22 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 21:13:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/713261869cc5445c5a50c1e9187de53e440add6d
Cr-Commit-Position: refs/heads/master@{#373035}

Powered by Google App Engine
This is Rietveld 408576698