Issue 16492002: Revert r203922, "Quickly close tabs/window with long-running unload handlers."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16492002: Revert r203922, "Quickly close tabs/window with long-running unload handlers." (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)

Modified:
7 years, 6 months ago

Reviewers:

CC:
chromium-reviews, joi+watch-content_chromium.org, tfarina, jam, sail+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert r203922, "Quickly close tabs/window with long-running unload handlers." BUG=142458, 156896, 247023 TEST=crashes go away TBR=jeremy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204355

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -584 lines)			Patch
M	chrome/browser/ui/browser.h	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	3 chunks	+6 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller.mm	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/unload_controller.h	View	6 chunks	+28 lines, -67 lines	0 comments	Download
M	chrome/browser/ui/unload_controller.cc	View	8 chunks	+78 lines, -175 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/unload_browsertest.cc	View	1 chunk	+0 lines, -205 lines	0 comments	Download
D	chrome/test/data/fast_tab_close/no_listeners.html	View	1 chunk	+0 lines, -11 lines	0 comments	Download
D	chrome/test/data/fast_tab_close/unload_sets_cookie.html	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	chrome/test/data/fast_tab_close/unload_sleep_before_cookie.html	View	1 chunk	+0 lines, -28 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	4 chunks	+5 lines, -25 lines	0 comments	Download
M	content/public/browser/web_contents.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download

Total messages: 1 (0 generated)

Avi (use Gerrit)

7 years, 6 months ago (2013-06-05 23:27:58 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r204355 (presubmit successful).