Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1649183002: Don't update the title to about:blank on first show for custom tabs (Closed)

Created:
4 years, 10 months ago by Yusuf
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Don't update the title to about:blank on first show for custom tabs Currently custom tabs don't show a title if the title is still the url, but due to optimizations inside warmup(), the title might end up being about:blank (even if the current url is not about:blank). The domain explicitly guards against this but title doesn't. Update the title to also never show about:blank BUG=579647 Committed: https://chromium.googlesource.com/chromium/src/+/3cf7fe595ce982437a875af505f4750b9309c435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Yusuf
4 years, 10 months ago (2016-01-29 23:32:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3cf7fe595ce982437a875af505f4750b9309c435.

Powered by Google App Engine
This is Rietveld 408576698