Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 164913004: Chromium plumbing for Screen Orientation API orientationchange events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use enum + android backend Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index 89a1e5ac15962e780e4db6f6dcdfe1e094f470a8..943aa06433bd00b08860fe7aed60c9b433440c2c 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -30,6 +30,7 @@
#include "content/browser/renderer_host/render_view_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_view_android.h"
+#include "content/browser/screen_orientation/screen_orientation_dispatcher_host.h"
#include "content/browser/ssl/ssl_host_state.h"
#include "content/browser/web_contents/web_contents_view_android.h"
#include "content/common/input/web_input_event_traits.h"
@@ -1781,6 +1782,31 @@ void ContentViewCoreImpl::SendOrientationChangeEventInternal() {
RenderViewHostImpl* rvhi = static_cast<RenderViewHostImpl*>(
web_contents_->GetRenderViewHost());
rvhi->SendOrientationChangeEvent(device_orientation_);
+
+ // TODO(mlamouri): temporary plumbing for Screen Orientation, this will change
+ // in the future. It might leave ContentViewCoreImpl or simply replace the
+ // SendOrientationChangeEvent call above.
+ blink::WebScreenOrientation orientation =
+ blink::WebScreenOrientationPortraitPrimary;
+
+ switch (device_orientation_) {
+ case 0:
+ orientation = blink::WebScreenOrientationPortraitPrimary;
+ break;
+ case 90:
+ orientation = blink::WebScreenOrientationLandscapePrimary;
+ break;
+ case -90:
+ orientation = blink::WebScreenOrientationLandscapeSecondary;
+ break;
+ case 180:
+ orientation = blink::WebScreenOrientationPortraitSecondary;
+ break;
jochen (gone - plz use gerrit) 2014/02/24 14:08:26 default: NOTREACHED()?
mlamouri (slow - plz ping) 2014/02/24 14:20:21 Done.
+ }
+
+ static_cast<RenderProcessHostImpl*>(web_contents_->GetRenderProcessHost())->
+ screen_orientation_dispatcher_host()->
+ OnOrientationChange(orientation);
}
void ContentViewCoreImpl::ExtractSmartClipData(JNIEnv* env,

Powered by Google App Engine
This is Rietveld 408576698