content/common/screen_orientation_messages.h - Issue 164913004: Chromium plumbing for Screen Orientation API orientationchange events.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/screen_orientation_messages.h

Issue 164913004: Chromium plumbing for Screen Orientation API orientationchange events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use enum + android backend Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/android/content_view_core_impl.cc ('K') | « content/common/content_message_generator.h ('k') | content/content_browser.gypi » ('j') | content/renderer/screen_orientation/screen_orientation_dispatcher_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // IPC messages for screen orientation.

	6 // Multiply-included message file, hence no include guard.

	7

	8 #include "ipc/ipc_message_macros.h"

	9 #include "third_party/WebKit/public/platform/WebScreenOrientation.h"

	10

	11 #undef IPC_MESSAGE_EXPORT

	12 #define IPC_MESSAGE_EXPORT CONTENT_EXPORT

	13

	14 #define IPC_MESSAGE_START ScreenOrientationMsgStart

	15

	16 IPC_ENUM_TRAITS(blink::WebScreenOrientation)
	jochen (gone - plz use gerrit) 2014/02/24 14:08:26 nit. use IPC_ENUM_TRAITS_MAX_VALUE nit. use IPC_ENUM_TRAITS_MAX_VALUE mlamouri (slow - plz ping) 2014/02/24 14:20:21 I can't because blink::WebScreenOrientation is a b Show quoted text On 2014/02/24 14:08:26, jochen wrote: > nit. use IPC_ENUM_TRAITS_MAX_VALUE I can't because blink::WebScreenOrientation is a bit field so the expected values are 0b0001, 0b0010, 0b0100, 0b1000. Actually, when I say I can't, I am exaggerating, it's just that using IPC_ENUM_TRAITS_MAX_VALUE would not help.
	17

	18 // The browser process informs the renderer process that the screen orientation

	19 // has changed. \|orientation\| contains the new screen orientation in degrees.

	20 IPC_MESSAGE_CONTROL1(ScreenOrientationMsg_OrientationChange,

	21 blink::WebScreenOrientation /* orientation */ )

OLD	NEW