Add MessagePipe interface. Use it in ChannelDispatcherBase.

remoting/protocol/channel_dispatcher_base.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_CHANNEL_DISPATCHER_BASE_H_
 #define REMOTING_PROTOCOL_CHANNEL_DISPATCHER_BASE_H_
 
 #include <string>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "remoting/base/buffered_socket_writer.h"
 #include "remoting/protocol/errors.h"
-#include "remoting/protocol/message_reader.h"
+#include "remoting/protocol/stream_message_pipe_adapter.h"
 
 namespace remoting {
 namespace protocol {
 
 class StreamChannelFactory;
 
 // Base class for channel message dispatchers. It's responsible for
 // creating the named channel. Derived dispatchers then dispatch
 // incoming messages on this channel as well as send outgoing
 // messages.
@@ skipping 16 matching lines @@
 
   virtual ~ChannelDispatcherBase();
 
   // Creates and connects the channel in the specified
   // |session|. Caller retains ownership of the Session.
   void Init(StreamChannelFactory* channel_factory, EventHandler* event_handler);
 
   const std::string& channel_name() { return channel_name_; }
 
   // Returns true if the channel is currently connected.
-  bool is_connected() { return channel_ != nullptr; }
+  bool is_connected() { return message_pipe() != nullptr; }

[Jamie, 2016/02/01 22:48:20]

message_pipe() can never return null with this implementation. I think you
probably want an is_initialized() method on 
StreamMessagePipeAdapter and call that here (or track initialization of this
class explicitly).

[Sergey Ulanov, 2016/02/02 21:16:42]

Replaced message_pipe_ with a scoped_ptr.

 
  protected:
   explicit ChannelDispatcherBase(const char* channel_name);
 
-  BufferedSocketWriter* writer() { return &writer_; }
+  MessagePipe* message_pipe() { return &message_pipe_; }
 
-  // Should be overridden in child classes to handle incoming messages.
   virtual void OnIncomingMessage(scoped_ptr<CompoundBuffer> message);
 
  private:
   void OnChannelReady(scoped_ptr<P2PStreamSocket> socket);
-  void OnReadWriteFailed(int error);
+  void OnPipeError(int error);
 
   std::string channel_name_;
   StreamChannelFactory* channel_factory_;
   EventHandler* event_handler_;
-  scoped_ptr<P2PStreamSocket> channel_;
 
-  BufferedSocketWriter writer_;
-  MessageReader reader_;
+  StreamMessagePipeAdapter message_pipe_;
 
   DISALLOW_COPY_AND_ASSIGN(ChannelDispatcherBase);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_CHANNEL_DISPATCHER_BASE_H_