Move SkColorMatrixFilter implementation to core.

Move SkColorMatrixFilter implementation to core.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1648933002

Committed: https://skia.googlesource.com/skia/+/8610002ff81fb5d81d1b7c312b5d0a8b05b41e13

[bsalomon, 2016-01-29 14:11:16]

Description was changed from

==========
Move SkColorMatrix[Filter] to core
==========

to

==========
Move SkColorMatrix[Filter] to core
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-29 14:12:00]

Description was changed from

==========
Move SkColorMatrix[Filter] to core
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Move SkColorMatrix[Filter] to core
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

TBR=reed@google.com
==========

[bsalomon, 2016-01-29 14:12:00]

bsalomon@google.com changed reviewers:
+ reed@google.com

[bsalomon, 2016-01-29 14:12:03]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-01-29 14:12:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648933002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648933002/1

[bsalomon, 2016-01-29 14:12:32]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2016-01-29 14:13:43]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-01-29 14:13:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648933002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648933002/1

[bsalomon, 2016-01-29 14:15:42]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2016-01-29 15:37:29]

Description was changed from

==========
Move SkColorMatrix[Filter] to core
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

TBR=reed@google.com
==========

to

==========
Move SkColorMatrixFilter implementation to core.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-01-29 15:37:38]

PTAL

https://codereview.chromium.org/1648933002/diff/40001/src/core/SkColorMatrixF...
File src/core/SkColorMatrixFilterRowMajor255.h (left):

https://codereview.chromium.org/1648933002/diff/40001/src/core/SkColorMatrixF...
src/core/SkColorMatrixFilterRowMajor255.h:35: SkColorFilter* newComposed(const
SkColorFilter*) const override;
This wasn't used anywhere and the implementation would rely on pulling
SkColorMatrix.h into core as well.

[reed1, 2016-01-29 17:09:18]

how will blink compile if we have removed the header from include/effects?

https://codereview.chromium.org/1648933002/diff/80001/src/core/SkColorFilter.cpp
File src/core/SkColorFilter.cpp (right):

https://codereview.chromium.org/1648933002/diff/80001/src/core/SkColorFilter....
src/core/SkColorFilter.cpp:157: SkColorFilter*
SkColorFilter::CreateMatrixFilterRowMajor255(const SkScalar array[20]) {
I think it cleaner to move this into the new .cpp file itself, so that this file
need not be changed at all.

[bsalomon, 2016-01-29 19:30:39]

On 2016/01/29 17:09:18, reed1 wrote:
> how will blink compile if we have removed the header from include/effects?
> 

I think the D means that I only deleted lines from the file, not that the file
is deleted. (At least locally it is not deleted and if you expand it on Rietveld
only the expected lines are removed, not the whole file).

>
https://codereview.chromium.org/1648933002/diff/80001/src/core/SkColorFilter.cpp
> File src/core/SkColorFilter.cpp (right):
> 
>
https://codereview.chromium.org/1648933002/diff/80001/src/core/SkColorFilter....
> src/core/SkColorFilter.cpp:157: SkColorFilter*
> SkColorFilter::CreateMatrixFilterRowMajor255(const SkScalar array[20]) {
> I think it cleaner to move this into the new .cpp file itself, so that this
file
> need not be changed at all.

Will do

[bsalomon, 2016-01-29 19:38:24]

PTAL

[reed1, 2016-01-29 19:42:20]

lets file a bug to remind us(me) to cleanup the public API (naming, transpose,
normalization)

lgtm

[bsalomon, 2016-01-29 20:32:38]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2016-01-29 20:32:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648933002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648933002/100001

[commit-bot: I haz the power, 2016-01-29 20:36:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 20:36:48]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[bsalomon, 2016-02-01 19:57:36]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-02-01 19:57:37]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1648933002/#ps120001
(title: "add back newComposed override")

[commit-bot: I haz the power, 2016-02-01 19:57:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648933002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648933002/120001

[commit-bot: I haz the power, 2016-02-01 20:09:09]

Description was changed from

==========
Move SkColorMatrixFilter implementation to core.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Move SkColorMatrixFilter implementation to core.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8610002ff81fb5d81d1b7c312b5d0a8b05b41e13
==========

[commit-bot: I haz the power, 2016-02-01 20:09:10]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/8610002ff81fb5d81d1b7c312b5d0a8b05b41e13