pkg/scheduled_test: formatter

pkg/scheduled_test/lib/descriptor.dart

Index: pkg/scheduled_test/lib/descriptor.dart
diff --git a/pkg/scheduled_test/lib/descriptor.dart b/pkg/scheduled_test/lib/descriptor.dart
index 0004236695c080ee7b4d6650ff8678168ea3e03c..16f10d50206ec387c3974562cf93dd5733ca4b19 100644
--- a/pkg/scheduled_test/lib/descriptor.dart
+++ b/pkg/scheduled_test/lib/descriptor.dart
@@ -100,7 +100,7 @@ FileDescriptor file(String name, [String contents='']) =>
 
 /// Creates a new binary [FileDescriptor] descriptor with [name] and [contents].
 FileDescriptor binaryFile(String name, List<int> contents) =>
-  new FileDescriptor.binary(name, contents);
+    new FileDescriptor.binary(name, contents);

[nweiz, 2014/02/13 22:01:53]

I don't like this change. I think "=>" methods should be allowed to be indented
two spaces, since they're effectively method bodies. I don't think switching
from "{}" to "=>" should require changing the body's indentation.

[kevmoo, 2014/02/17 20:00:19]

If a line is considered a continuation, its indent is 4.

This is consistent with our other styles.

[nweiz, 2014/02/19 21:13:46]

I don't think these lines should be considered continuations, since they're
effectively the body of the function.

[Bob Nystrom, 2014/02/19 21:18:54]

Except that unlike method bodies, they implicitly return their result. When
converting from one to the other, it's easy to forget to add/remove the
"return".

I think it's worth having different indentation to highlight that fact.

[nweiz, 2014/02/19 21:33:56]

I don't agree, but it seems I'm in the minority on this so I'll switch.

 
 /// Creates a new text [FileDescriptor] with [name] that matches its String
 /// contents against [matcher]. If the file is created, it's considered to be
@@ -112,16 +112,15 @@ FileDescriptor matcherFile(String name, matcher) =>
 /// contents against [matcher]. If the file is created, it's considered to be
 /// empty.
 FileDescriptor binaryMatcherFile(String name, matcher) =>
-  new FileDescriptor.binaryMatcher(name, wrapMatcher(matcher));
+    new FileDescriptor.binaryMatcher(name, wrapMatcher(matcher));
 
 /// Creates a new [DirectoryDescriptor] descriptor with [name] and [contents].
 DirectoryDescriptor dir(String name, [Iterable<Descriptor> contents]) =>
-   new DirectoryDescriptor(name, contents == null? <Descriptor>[] : contents);
+    new DirectoryDescriptor(name, contents == null ? <Descriptor>[] : contents);
 
 /// Creates a new descriptor wrapping a [Future]. This descriptor forwards all
 /// asynchronous operations to the result of [future].
-AsyncDescriptor async(Future<Descriptor> future) =>
-  new AsyncDescriptor(future);
+AsyncDescriptor async(Future<Descriptor> future) => new AsyncDescriptor(future);
 
 /// Creates a new [NothingDescriptor] descriptor that asserts that no entry
 /// named [name] exists.
@@ -131,7 +130,7 @@ NothingDescriptor nothing(String name) => new NothingDescriptor(name);
 /// a name matching [pattern] exists, and matches the [Descriptor] returned
 /// by [fn].
 PatternDescriptor pattern(Pattern name, EntryCreator fn) =>
-  new PatternDescriptor(name, fn);
+    new PatternDescriptor(name, fn);
 
 /// A convenience method for creating a [PatternDescriptor] descriptor that
 /// constructs a [FileDescriptor] descriptor.
@@ -141,4 +140,4 @@ PatternDescriptor filePattern(Pattern name, [String contents='']) =>
 /// A convenience method for creating a [PatternDescriptor] descriptor that
 /// constructs a [DirectoryDescriptor] descriptor.
 PatternDescriptor dirPattern(Pattern name, [Iterable<Descriptor> contents]) =>
-  pattern(name, (realName) => dir(realName, contents));
+    pattern(name, (realName) => dir(realName, contents));