mojo/dart/packages/mojo_services/lib/mojo/media/media_player.mojom.dart - Issue 1648803006: Expose Service Describer in Dart mojo package

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/packages/mojo_services/lib/mojo/media/media_player.mojom.dart

Issue 1648803006: Expose Service Describer in Dart mojo package (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Rebase Retest and Update Mojoms Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/dart/packages/mojo/lib/src/service_describer.dart ('K') | « mojo/dart/packages/mojo_services/lib/mojo/media/media_pipe.mojom.dart ('k') | mojo/dart/packages/mojo_services/lib/mojo/media/media_sink.mojom.dart » ('j') | mojo/dart/unittests/embedder_tests/bindings_generation_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/dart/packages/mojo_services/lib/mojo/media/media_player.mojom.dart

diff --git a/mojo/dart/packages/mojo_services/lib/mojo/media/media_player.mojom.dart b/mojo/dart/packages/mojo_services/lib/mojo/media/media_player.mojom.dart

index efc90ea97f9ea0fb34aadeb769a99a8d5dde8539..b5435eb733eab6a423fd06c697c287d80f203092 100644

--- a/mojo/dart/packages/mojo_services/lib/mojo/media/media_player.mojom.dart

+++ b/mojo/dart/packages/mojo_services/lib/mojo/media/media_player.mojom.dart

@@ -414,11 +414,14 @@ const int _MediaPlayer_getStatusName = 2;

class _MediaPlayerServiceDescription implements service_describer.ServiceDescription {

- dynamic getTopLevelInterface([Function responseFactory]) => null;

+ dynamic getTopLevelInterface([Function responseFactory]) =>

+ responseFactory(null);

- dynamic getTypeDefinition(String typeKey, [Function responseFactory]) => null;

+ dynamic getTypeDefinition(String typeKey, [Function responseFactory]) =>

+ responseFactory(null);

- dynamic getAllTypeDefinitions([Function responseFactory]) => null;

+ dynamic getAllTypeDefinitions([Function responseFactory]) =>

+ responseFactory(null);

}

abstract class MediaPlayer {

@@ -660,7 +663,7 @@ class MediaPlayerStub extends bindings.Stub {

int get version => 0;

- service_describer.ServiceDescription get serviceDescription =>

+ static service_describer.ServiceDescription get serviceDescription =>

new _MediaPlayerServiceDescription();

}