mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart - Issue 1648803006: Expose Service Describer in Dart mojo package

Unified Diff: mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart

Issue 1648803006: Expose Service Describer in Dart mojo package (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Rebase Retest and Update Mojoms Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/dart/apptests/test_apps/echo_with_service_describer/pubspec.yaml ('k') | mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import.mojom.dart » ('j') | mojo/dart/packages/mojo/lib/src/application_connection.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart

diff --git a/mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart b/mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart

index bd52e433899cb2a0a52e613d41d64ee6f3259fd4..5bd818ac69c7a2e1d982144a93b36cc87153cdd4 100644

--- a/mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart

+++ b/mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart

@@ -1128,13 +1128,13 @@ mojom_types.MojomInterface _dartToCppCppSide() {

class _CppSideServiceDescription implements service_describer.ServiceDescription {

dynamic getTopLevelInterface([Function responseFactory]) =>

- _dartToCppCppSide();

+ responseFactory(_dartToCppCppSide());

dynamic getTypeDefinition(String typeKey, [Function responseFactory]) =>

- getAllMojomTypeDefinitions()[typeKey];

+ responseFactory(getAllMojomTypeDefinitions()[typeKey]);

dynamic getAllTypeDefinitions([Function responseFactory]) =>

- getAllMojomTypeDefinitions();

+ responseFactory(getAllMojomTypeDefinitions());

}

abstract class CppSide {

@@ -1347,7 +1347,7 @@ class CppSideStub extends bindings.Stub {

int get version => 0;

- service_describer.ServiceDescription get serviceDescription =>

+ static service_describer.ServiceDescription get serviceDescription =>

zra 2016/02/10 22:48:24 Does each access to the getter need to provide a u

alexfandrianto 2016/02/11 01:04:54 Done.

new _CppSideServiceDescription();

}

@@ -1382,13 +1382,13 @@ mojom_types.MojomInterface _dartToCppDartSide() {

class _DartSideServiceDescription implements service_describer.ServiceDescription {

dynamic getTopLevelInterface([Function responseFactory]) =>

- _dartToCppDartSide();

+ responseFactory(_dartToCppDartSide());