mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart - Issue 1648803006: Expose Service Describer in Dart mojo package

Unified Diff: mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart

Issue 1648803006: Expose Service Describer in Dart mojo package (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Address zra's feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart ('k') | mojo/dart/packages/mojo/lib/application.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart

diff --git a/mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart b/mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart

index 69399b2fc2cfb22eb70399f676201276222866c3..5031c4741b1e493531e330b481bb02222cad0856 100644

--- a/mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart

+++ b/mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart

@@ -855,13 +855,13 @@ mojom_types.MojomInterface _pingpongServicePingPongService() {

class _PingPongServiceServiceDescription implements service_describer.ServiceDescription {

dynamic getTopLevelInterface([Function responseFactory]) =>

- _pingpongServicePingPongService();

+ responseFactory(_pingpongServicePingPongService());

dynamic getTypeDefinition(String typeKey, [Function responseFactory]) =>

- getAllMojomTypeDefinitions()[typeKey];

+ responseFactory(getAllMojomTypeDefinitions()[typeKey]);

dynamic getAllTypeDefinitions([Function responseFactory]) =>

- getAllMojomTypeDefinitions();

+ responseFactory(getAllMojomTypeDefinitions());

}

abstract class PingPongService {

@@ -1192,8 +1192,13 @@ class PingPongServiceStub extends bindings.Stub {

int get version => 0;

- service_describer.ServiceDescription get serviceDescription =>

- new _PingPongServiceServiceDescription();

+ static service_describer.ServiceDescription _cachedServiceDescription;

+ static service_describer.ServiceDescription get serviceDescription {

+ if (_cachedServiceDescription == null) {

+ _cachedServiceDescription = new _PingPongServiceServiceDescription();

+ }

+ return _cachedServiceDescription;

+ }

}

const int _PingPongClient_pongName = 0;

@@ -1215,13 +1220,13 @@ mojom_types.MojomInterface _pingpongServicePingPongClient() {

class _PingPongClientServiceDescription implements service_describer.ServiceDescription {

dynamic getTopLevelInterface([Function responseFactory]) =>

- _pingpongServicePingPongClient();

+ responseFactory(_pingpongServicePingPongClient());