mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart - Issue 1648803006: Expose Service Describer in Dart mojo package

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart

Issue 1648803006: Expose Service Describer in Dart mojo package (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Address zra's feedback Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/validation_test_interfaces.mojom.dart ('k') | mojo/dart/packages/_mojo_for_test_only/lib/regression_tests/regression_tests.mojom.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart

diff --git a/mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart b/mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart

index dc13a6b7fc9f88efc23a0a8b69d95b1ff21d58c3..42564b628fa6c924793330c9347a78263be31341 100644

--- a/mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart

+++ b/mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart

@@ -993,13 +993,13 @@ mojom_types.MojomInterface _versioningTestClientHumanResourceDatabase() {

class _HumanResourceDatabaseServiceDescription implements service_describer.ServiceDescription {

dynamic getTopLevelInterface([Function responseFactory]) =>

- _versioningTestClientHumanResourceDatabase();

+ responseFactory(_versioningTestClientHumanResourceDatabase());

dynamic getTypeDefinition(String typeKey, [Function responseFactory]) =>

- getAllMojomTypeDefinitions()[typeKey];

+ responseFactory(getAllMojomTypeDefinitions()[typeKey]);

dynamic getAllTypeDefinitions([Function responseFactory]) =>

- getAllMojomTypeDefinitions();

+ responseFactory(getAllMojomTypeDefinitions());

}

abstract class HumanResourceDatabase {

@@ -1385,8 +1385,13 @@ class HumanResourceDatabaseStub extends bindings.Stub {

int get version => 1;

- service_describer.ServiceDescription get serviceDescription =>

- new _HumanResourceDatabaseServiceDescription();

+ static service_describer.ServiceDescription _cachedServiceDescription;

+ static service_describer.ServiceDescription get serviceDescription {

+ if (_cachedServiceDescription == null) {

+ _cachedServiceDescription = new _HumanResourceDatabaseServiceDescription();

+ }

+ return _cachedServiceDescription;

+ }

}