chrome/browser/resources/md_history/history.js - Issue 1648803003: MD History: Drop-down menu allows searching for history-items by domain name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/history.js

Issue 1648803003: MD History: Drop-down menu allows searching for history-items by domain name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@search_functionality

Patch Set: Address reviewer comments and small fixes. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/md_history/history_card_manager.js » ('j') | chrome/browser/resources/md_history/history_card_manager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/history.js

diff --git a/chrome/browser/resources/md_history/history.js b/chrome/browser/resources/md_history/history.js

index 276e62544bdaaa59d5781a389b045d63ce4d3c7f..242e533f84432dd04fe5e9bf46edcccbf20f307b 100644

--- a/chrome/browser/resources/md_history/history.js

+++ b/chrome/browser/resources/md_history/history.js

@@ -61,9 +61,12 @@ window.addEventListener('resize', function() {

/**

* When the search is changed refresh the results and load either search results

- * or normal history results.

+ * or normal history results. If they are search results, make sure the search

+ * bar reflects the search term being used.

window.addEventListener('refresh-results', function(e) {

+ if (e.detail.search != '')

+ $('toolbar').setSearchTerm(e.detail.search);

$('history-card-manager').resetHistoryResults();

chrome.send('queryHistory', [e.detail.search, 0, 0, 0, RESULTS_PER_PAGE]);

});

« no previous file with comments | « no previous file | chrome/browser/resources/md_history/history_card_manager.js » ('j') | chrome/browser/resources/md_history/history_card_manager.js » ('J')