Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 16488003: Add the following xkb layouts (Closed)

Created:
7 years, 6 months ago by jungshik at Google
Modified:
7 years, 6 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, nkostylev+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Add the following xkb layouts xkb:cz:qwerty:cze Czech(Qwerty) xkb:am:phonetic:arm Armenian(Phonetic) xkb:ge::geo Georgian xkb:by::bel Belarusian xkb:mn::mon Mongolian BUG=127135, 229277, 229281, 229283, 229284, 229285 TEST=Build chromeos-chrome and emerge/gmerge to Chrome OS. See if the above keyboards are available for addition. Once added, try them and see if they work.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M chromeos/ime/input_methods.txt View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jungshik at Google
7 years, 6 months ago (2013-06-07 20:46:16 UTC) #1
Seigo Nonaka
lgtm lgtm, thank you for taking!
7 years, 6 months ago (2013-06-10 02:37:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/16488003/13001
7 years, 6 months ago (2013-06-12 16:54:26 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-12 20:41:58 UTC) #4
Retried try job too often on win_rel for step(s) chrome_frame_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698