Adds SecurityContext.useCertificateChainBytes

Adds SecurityContext.useCertificateChainBytes

Changes SecurityContext.useCertificateChain to call the new method and
return a Future.

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/8f356bf87ef2fa85559f821a4842b85a31d1cfeb

[zra, 2016-01-29 17:45:18]

zra@google.com changed reviewers:
+ iposva@google.com, whesse@google.com

[Bill Hesse, 2016-02-01 18:20:11]

I don't understand why these are called "UseXAsBytes" instead of "UseXBytes" or
fromBytes.  The certificates or keys are not being used as bytes.  Their bytes
are being used, or something from the bytes are being used.

Everything else looks good.

[zra, 2016-02-01 19:04:55]

On 2016/02/01 18:20:11, Bill Hesse wrote:
> I don't understand why these are called "UseXAsBytes" instead of "UseXBytes"
or
> fromBytes.  The certificates or keys are not being used as bytes.  Their bytes
> are being used, or something from the bytes are being used.
> 
> Everything else looks good.

I may have misunderstood a suggestion from an email thread. I've changed it to
"UseXBytes".

[zra, 2016-02-01 19:18:49]

Description was changed from

==========
Adds SecurityContext.useCertificateChainAsBytes

Changes SecurityContext.useCertificateChain to call the new method and
return a Future.
==========

to

==========
Adds SecurityContext.useCertificateChainBytes

Changes SecurityContext.useCertificateChain to call the new method and
return a Future.
==========

[zra, 2016-02-02 16:53:48]

ping

[Bill Hesse, 2016-02-02 18:36:30]

LGTM, thanks.

[zra, 2016-02-02 18:54:10]

Description was changed from

==========
Adds SecurityContext.useCertificateChainBytes

Changes SecurityContext.useCertificateChain to call the new method and
return a Future.
==========

to

==========
Adds SecurityContext.useCertificateChainBytes

Changes SecurityContext.useCertificateChain to call the new method and
return a Future.

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8f356bf87ef2fa85559f821a4842b85a31d1cfeb
==========

[zra, 2016-02-02 18:54:11]

Committed patchset #7 (id:120001) manually as
8f356bf87ef2fa85559f821a4842b85a31d1cfeb (presubmit successful).

[kevmoo, 2016-02-02 19:02:34]

On 2016/02/02 18:54:11, zra wrote:
> Committed patchset #7 (id:120001) manually as
> 8f356bf87ef2fa85559f821a4842b85a31d1cfeb (presubmit successful).

Please update changelog, too :-)

[Paul Berry, 2016-02-02 20:22:05]

paulberry@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2016-02-02 20:22:05]

This CL broke some analyzer tests.  The analyzer bot is stalled for some reason,
but you should be able to reproduce locally with:

./tools/test.py -aia32 --checked --mode release --compiler dart2analyzer
--runtime none --progress color --report standalone

Example failure:

FAILED: dart2analyzer-none-checked release_ia32
standalone/io/raw_secure_socket_test
Expected: Pass 
Actual: StaticWarning
CommandOutput[dart2analyzer]:

stderr:
WARNING|STATIC_TYPE_WARNING|UNDEFINED_METHOD|/usr/local/google/home/paulberry/dart-new/sdk/tests/standalone/io/raw_secure_socket_test.dart|20|5|24|The
method 'useCertificateChainBytes' is not defined for the class 'SecurityContext'
WARNING|STATIC_TYPE_WARNING|UNDEFINED_METHOD|/usr/local/google/home/paulberry/dart-new/sdk/tests/standalone/io/raw_secure_socket_test.dart|21|5|18|The
method 'usePrivateKeyBytes' is not defined for the class 'SecurityContext'


Command[dart2analyzer]: DART_CONFIGURATION=ReleaseIA32 sdk/bin/dartanalyzer
--ignore-unrecognized-flags --show-package-warnings --enable-async
--package-root=out/ReleaseIA32/packages/ --machine --no-hints
/usr/local/google/home/paulberry/dart-new/sdk/tests/standalone/io/raw_secure_socket_test.dart
--enable_type_checks
Took 0:00:00.035000

Short reproduction command (experimental):
    python tools/test.py -aia32 --checked -mrelease -cdart2analyzer -rnone -t240
standalone/io/raw_secure_socket_test

[zra, 2016-02-02 20:39:51]

On 2016/02/02 20:22:05, Paul Berry wrote:
> This CL broke some analyzer tests.  The analyzer bot is stalled for some
reason,
> but you should be able to reproduce locally with:
> 
> ./tools/test.py -aia32 --checked --mode release --compiler dart2analyzer
> --runtime none --progress color --report standalone
> 
> Example failure:
> 
> FAILED: dart2analyzer-none-checked release_ia32
> standalone/io/raw_secure_socket_test
> Expected: Pass 
> Actual: StaticWarning
> CommandOutput[dart2analyzer]:
> 
> stderr:
>
WARNING|STATIC_TYPE_WARNING|UNDEFINED_METHOD|/usr/local/google/home/paulberry/dart-new/sdk/tests/standalone/io/raw_secure_socket_test.dart|20|5|24|The
> method 'useCertificateChainBytes' is not defined for the class
'SecurityContext'
>
WARNING|STATIC_TYPE_WARNING|UNDEFINED_METHOD|/usr/local/google/home/paulberry/dart-new/sdk/tests/standalone/io/raw_secure_socket_test.dart|21|5|18|The
> method 'usePrivateKeyBytes' is not defined for the class 'SecurityContext'
> 
> 
> Command[dart2analyzer]: DART_CONFIGURATION=ReleaseIA32 sdk/bin/dartanalyzer
> --ignore-unrecognized-flags --show-package-warnings --enable-async
> --package-root=out/ReleaseIA32/packages/ --machine --no-hints
>
/usr/local/google/home/paulberry/dart-new/sdk/tests/standalone/io/raw_secure_socket_test.dart
> --enable_type_checks
> Took 0:00:00.035000
> 
> Short reproduction command (experimental):
>     python tools/test.py -aia32 --checked -mrelease -cdart2analyzer -rnone
-t240
> standalone/io/raw_secure_socket_test

Thanks. Should be fixed by:

https://codereview.chromium.org/1660023002/

[zra, 2016-02-02 21:27:09]

On 2016/02/02 19:02:34, kevmoo wrote:
> On 2016/02/02 18:54:11, zra wrote:
> > Committed patchset #7 (id:120001) manually as
> > 8f356bf87ef2fa85559f821a4842b85a31d1cfeb (presubmit successful).
> 
> Please update changelog, too :-)

Updating in next CL. https://codereview.chromium.org/1665433002/