Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1648783003: Do not attempt to show the paste popup if the view is detached. (Closed)

Created:
4 years, 10 months ago by Ted C
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not attempt to show the paste popup if the view is detached. BUG=581949 Committed: https://crrev.com/735ec4fc8f8857063fc8093b6e7eb256f1f74906 Cr-Commit-Position: refs/heads/master@{#372188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ted C
PTAL I couldn't repro the bug, but the failure cause makes sense.
4 years, 10 months ago (2016-01-28 21:16:33 UTC) #2
aelias_OOO_until_Jul13
lgtm
4 years, 10 months ago (2016-01-28 21:18:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648783003/1
4 years, 10 months ago (2016-01-28 21:21:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 22:42:35 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 22:43:47 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/735ec4fc8f8857063fc8093b6e7eb256f1f74906
Cr-Commit-Position: refs/heads/master@{#372188}

Powered by Google App Engine
This is Rietveld 408576698