[generators] Remove full-codegen implementation of yield*.

[generators] Remove full-codegen implementation of yield*.

The recently introduced desugaring of yield* renders this code dead.

BUG=

Committed: https://crrev.com/9096aef4c171fc0e6b4f0d97ff4dd7d4fcf312bd
Cr-Commit-Position: refs/heads/master@{#33762}

[neis, 2016-01-29 09:28:10]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 09:28:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648773003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648773003/1

[neis, 2016-01-29 09:39:25]

Description was changed from

==========
[generators] Remove full-codegen implementation of yield*.

Since we desugar yield*, this is dead code.

BUG=
==========

to

==========
[generators] Remove full-codegen implementation of yield*.

The recently introduced desugaring of yield* renders this code dead.

BUG=
==========

[neis, 2016-01-29 09:39:46]

neis@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[neis, 2016-01-29 09:39:54]

PTAL

[Michael Starzinger, 2016-01-29 09:48:54]

Instant-LGTM of course. Just one comment to address.

https://codereview.chromium.org/1648773003/diff/1/src/runtime/runtime-generat...
File src/runtime/runtime-generator.cc (left):

https://codereview.chromium.org/1648773003/diff/1/src/runtime/runtime-generat...
src/runtime/runtime-generator.cc:61: // TODO(mstarzinger): This special case
disappears with do-expressions.
Woot! This the the awesomez! :)

https://codereview.chromium.org/1648773003/diff/1/src/runtime/runtime-generat...
File src/runtime/runtime-generator.cc (right):

https://codereview.chromium.org/1648773003/diff/1/src/runtime/runtime-generat...
src/runtime/runtime-generator.cc:39: DCHECK(args.length() == 1);
The declaration in runtime.h can be changed from "-1" arguments to "2" now.

[commit-bot: I haz the power, 2016-01-29 09:54:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 09:54:02]

Dry run: This issue passed the CQ dry run.

[neis, 2016-01-29 09:57:32]

On 2016/01/29 09:48:54, Michael Starzinger wrote:
> Instant-LGTM of course. Just one comment to address.
> 
>
https://codereview.chromium.org/1648773003/diff/1/src/runtime/runtime-generat...
> File src/runtime/runtime-generator.cc (left):
> 
>
https://codereview.chromium.org/1648773003/diff/1/src/runtime/runtime-generat...
> src/runtime/runtime-generator.cc:61: // TODO(mstarzinger): This special case
> disappears with do-expressions.
> Woot! This the the awesomez! :)
> 
>
https://codereview.chromium.org/1648773003/diff/1/src/runtime/runtime-generat...
> File src/runtime/runtime-generator.cc (right):
> 
>
https://codereview.chromium.org/1648773003/diff/1/src/runtime/runtime-generat...
> src/runtime/runtime-generator.cc:39: DCHECK(args.length() == 1);
> The declaration in runtime.h can be changed from "-1" arguments to "2" now.

Thanks, forgot that (I assume you meant 1, not 2).

[Michael Starzinger, 2016-01-29 10:09:31]

On 2016/01/29 09:57:32, neis wrote:
> On 2016/01/29 09:48:54, Michael Starzinger wrote:
> > Instant-LGTM of course. Just one comment to address.
> > 
> >
>
https://codereview.chromium.org/1648773003/diff/1/src/runtime/runtime-generat...
> > File src/runtime/runtime-generator.cc (left):
> > 
> >
>
https://codereview.chromium.org/1648773003/diff/1/src/runtime/runtime-generat...
> > src/runtime/runtime-generator.cc:61: // TODO(mstarzinger): This special case
> > disappears with do-expressions.
> > Woot! This the the awesomez! :)
> > 
> >
>
https://codereview.chromium.org/1648773003/diff/1/src/runtime/runtime-generat...
> > File src/runtime/runtime-generator.cc (right):
> > 
> >
>
https://codereview.chromium.org/1648773003/diff/1/src/runtime/runtime-generat...
> > src/runtime/runtime-generator.cc:39: DCHECK(args.length() == 1);
> > The declaration in runtime.h can be changed from "-1" arguments to "2" now.
> 
> Thanks, forgot that (I assume you meant 1, not 2).

Ooops, yes, "1" of course, thanks.

[neis, 2016-01-29 12:29:34]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 12:29:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648773003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648773003/40001

[commit-bot: I haz the power, 2016-01-29 12:57:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 12:57:16]

Dry run: This issue passed the CQ dry run.

[neis, 2016-02-05 08:07:56]

The CQ bit was checked by neis@chromium.org

[neis, 2016-02-05 08:07:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1648773003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-02-05 08:08:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648773003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648773003/60001

[commit-bot: I haz the power, 2016-02-05 08:53:45]

Description was changed from

==========
[generators] Remove full-codegen implementation of yield*.

The recently introduced desugaring of yield* renders this code dead.

BUG=
==========

to

==========
[generators] Remove full-codegen implementation of yield*.

The recently introduced desugaring of yield* renders this code dead.

BUG=
==========

[commit-bot: I haz the power, 2016-02-05 08:53:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-05 08:54:08]

Description was changed from

==========
[generators] Remove full-codegen implementation of yield*.

The recently introduced desugaring of yield* renders this code dead.

BUG=
==========

to

==========
[generators] Remove full-codegen implementation of yield*.

The recently introduced desugaring of yield* renders this code dead.

BUG=

Committed: https://crrev.com/9096aef4c171fc0e6b4f0d97ff4dd7d4fcf312bd
Cr-Commit-Position: refs/heads/master@{#33762}
==========

[commit-bot: I haz the power, 2016-02-05 08:54:09]

Patchset 4 (id:??) landed as
https://crrev.com/9096aef4c171fc0e6b4f0d97ff4dd7d4fcf312bd
Cr-Commit-Position: refs/heads/master@{#33762}