Issue 164873006: Do not share a GL context between CoreAnimation and async readback

Issue 164873006: Do not share a GL context between CoreAnimation and async readback (Closed)

Created:
6 years, 10 months ago by ccameron

Modified:
6 years, 10 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Do not share a GL context between CoreAnimation and async readback There is nothing in the documentation that suggests that this change is necessary -- nothing says that you can't use the GL context that CoreAnimation is using outside of CoreAnimation. So this patch is not well-informed, in that sense. That said, the crashes reported did not appear until I merged the two GL contexts. Also, locally, they went away as soon as I separated them back out. BUG=340385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252239

Patch Set 1 #

Patch Set 2 : More comments #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	content/browser/renderer_host/compositing_iosurface_context_mac.h	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
	M	content/browser/renderer_host/compositing_iosurface_layer_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

ccameron

Unfortunately I don't have a better motivation for this than empirical observations... we'll see how ...

6 years, 10 months ago (2014-02-19 20:59:16 UTC) #1

Ken Russell (switch to Gerrit)

LGTM if the browser still renders with this change.

6 years, 10 months ago (2014-02-19 23:31:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/164873006/30001

6 years, 10 months ago (2014-02-20 01:18:36 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/164873006/30001

6 years, 10 months ago (2014-02-20 05:07:48 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/164873006/30001

6 years, 10 months ago (2014-02-20 09:03:11 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/164873006/30001

6 years, 10 months ago (2014-02-20 12:27:01 UTC) #8

Message was sent while issue was closed.

Change committed as 252239

Expand Messages | Collapse Messages