mojo/public/bindings/generators/cpp_templates/enum_declaration.tmpl - Issue 164873002: Fix bug with using enums as default values in mojom. We were previously

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/public/bindings/generators/cpp_templates/enum_declaration.tmpl

Issue 164873002: Fix bug with using enums as default values in mojom. We were previously (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « mojo/apps/js/bindings/sample_service_unittests.js ('k') | mojo/public/bindings/generators/cpp_templates/struct_builder_definition.tmpl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 enum {{enum.name}} {	1 enum {{enum.name}} {

2 {%- for field in enum.fields %}	2 {%- for field in enum.fields %}

3 {%- if field.value %}	3 {%- if field.value %}

4 {{field.name}} = {{field.value}},	4 {{field.name}} = {{field.value\|expression_to_text(module)}},

5 {%- else %}	5 {%- else %}

6 {{field.name}},	6 {{field.name}},

7 {%- endif %}	7 {%- endif %}

8 {%- endfor %}	8 {%- endfor %}

9 };	9 };

OLD	NEW