Replace assert by explicit throw new AssertionError

Replace assert by explicit throw new AssertionError

Calling assert if shared RELRO config is illegal will not
catch this error, because assertions are generally inactive.
Replace assert with a log and explict throw AssertionError.

Shared RELRO config is a compile-time constant. It can only
be made illegal through serious coding error.

Committed: https://crrev.com/61defc5525dea54c1d74bd54c40f63974e25118b
Cr-Commit-Position: refs/heads/master@{#372648}

[simonb (inactive), 2016-01-28 18:29:10]

The CQ bit was checked by simonb@chromium.org to run a CQ dry run

[simonb (inactive), 2016-01-28 18:29:49]

simonb@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[commit-bot: I haz the power, 2016-01-28 18:30:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648713002/1

[commit-bot: I haz the power, 2016-01-28 20:00:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-28 20:00:33]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-01-29 08:29:43]

lgtm

[simonb (inactive), 2016-02-01 11:25:00]

The CQ bit was checked by simonb@chromium.org

[commit-bot: I haz the power, 2016-02-01 11:25:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648713002/1

[commit-bot: I haz the power, 2016-02-01 12:44:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-01 12:46:16]

Description was changed from

==========
Replace assert by explicit throw new AssertionError

Calling assert if shared RELRO config is illegal will not
catch this error, because assertions are generally inactive.
Replace assert with a log and explict throw AssertionError.

Shared RELRO config is a compile-time constant. It can only
be made illegal through serious coding error.
==========

to

==========
Replace assert by explicit throw new AssertionError

Calling assert if shared RELRO config is illegal will not
catch this error, because assertions are generally inactive.
Replace assert with a log and explict throw AssertionError.

Shared RELRO config is a compile-time constant. It can only
be made illegal through serious coding error.

Committed: https://crrev.com/61defc5525dea54c1d74bd54c40f63974e25118b
Cr-Commit-Position: refs/heads/master@{#372648}
==========

[commit-bot: I haz the power, 2016-02-01 12:46:16]

Patchset 1 (id:??) landed as
https://crrev.com/61defc5525dea54c1d74bd54c40f63974e25118b
Cr-Commit-Position: refs/heads/master@{#372648}