Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1648673002: Revert of [regexp] restrict pattern syntax for unicode mode. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
Reviewers:
vogelheim, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@stage
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] restrict pattern syntax for unicode mode. (patchset #6 id:120001 of https://codereview.chromium.org/1645573002/ ) Reason for revert: [Sheriff] Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/4222 Original issue's description: > [regexp] restrict pattern syntax for unicode mode. > > ES2015 Annex B.1.4 specifies a restricted pattern language for unicode > mode. This change reflects that, based on some test262 test cases. > > R=littledan@chromium.org > BUG=v8:2952 > LOG=N > > Committed: https://crrev.com/e918c4ec464456a374098049ca22eac2107f6223 > Cr-Commit-Position: refs/heads/master@{#33584} TBR=vogelheim@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:2952 Committed: https://crrev.com/8b5a7eb6bff7eaa6b4c289d46a579efe8cf67c9f Cr-Commit-Position: refs/heads/master@{#33588}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -154 lines) Patch
M src/regexp/regexp-parser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/regexp/regexp-parser.cc View 18 chunks +75 lines, -118 lines 0 comments Download
D test/mjsunit/harmony/unicode-regexp-restricted-syntax.js View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [regexp] restrict pattern syntax for unicode mode.
4 years, 10 months ago (2016-01-28 15:26:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648673002/1
4 years, 10 months ago (2016-01-28 15:26:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 15:26:58 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 15:27:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b5a7eb6bff7eaa6b4c289d46a579efe8cf67c9f
Cr-Commit-Position: refs/heads/master@{#33588}

Powered by Google App Engine
This is Rietveld 408576698