Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1648663002: Support hide annotations in diff_view. (Closed)

Created:
4 years, 10 months ago by Johnni Winther
Modified:
4 years, 10 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -25 lines) Patch
M tests/compiler/dart2js/sourcemaps/diff_view.dart View 5 chunks +41 lines, -25 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 10 months ago (2016-01-28 14:44:54 UTC) #2
asgerf
lgtm https://codereview.chromium.org/1648663002/diff/1/tests/compiler/dart2js/sourcemaps/diff_view.dart File tests/compiler/dart2js/sourcemaps/diff_view.dart (right): https://codereview.chromium.org/1648663002/diff/1/tests/compiler/dart2js/sourcemaps/diff_view.dart#newcode68 tests/compiler/dart2js/sourcemaps/diff_view.dart:68: options1, filename, addAnnotations: showAnnotations); Why not pick one ...
4 years, 10 months ago (2016-01-28 14:47:42 UTC) #3
Johnni Winther
Committed patchset #1 (id:1) manually as 40302e2933a0748ffc6eab24a1cef57724d3dacc (presubmit successful).
4 years, 10 months ago (2016-01-28 14:51:02 UTC) #5
Johnni Winther
4 years, 10 months ago (2016-01-28 14:51:25 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1648663002/diff/1/tests/compiler/dart2js/sour...
File tests/compiler/dart2js/sourcemaps/diff_view.dart (right):

https://codereview.chromium.org/1648663002/diff/1/tests/compiler/dart2js/sour...
tests/compiler/dart2js/sourcemaps/diff_view.dart:68: options1, filename,
addAnnotations: showAnnotations);
On 2016/01/28 14:47:42, asgerf wrote:
> Why not pick one name and stick with it.

Done.

Powered by Google App Engine
This is Rietveld 408576698