Issue 1648633003: Do not set root library to null while creating the snapshot, just use whatever is there, it is set …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1648633003: Do not set root library to null while creating the snapshot, just use whatever is there, it is set … (Closed)

Created:
4 years, 10 months ago by siva

Modified:
4 years, 10 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Do not set root library to null while creating the snapshot, just use whatever is there, it is set to null when creating the full snapshot, when we start doing full application snapshots this might not be null. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/b0e8c4bb058282122e014f542169a7d7957cf699

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	runtime/vm/dart_api_impl.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

siva

4 years, 10 months ago (2016-01-29 18:35:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b0e8c4bb058282122e014f542169a7d7957cf699 (presubmit successful).