Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1648633002: Update V8 to version 4.10.99. (Closed)

Created:
4 years, 10 months ago by v8-autoroll
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update V8 to version 4.10.99. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e77121fb..86e3d587 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Committed: https://crrev.com/cf82bf409d647e793c5c60aeb3dbf9f4aa13ced7 Cr-Commit-Position: refs/heads/master@{#372105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
v8-autoroll
4 years, 10 months ago (2016-01-28 11:47:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648633002/1
4 years, 10 months ago (2016-01-28 11:47:59 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/172728)
4 years, 10 months ago (2016-01-28 14:28:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648633002/1
4 years, 10 months ago (2016-01-28 14:30:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 16:45:29 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cf82bf409d647e793c5c60aeb3dbf9f4aa13ced7 Cr-Commit-Position: refs/heads/master@{#372105}
4 years, 10 months ago (2016-01-28 16:46:21 UTC) #10
joedow
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1645123002/ by joedow@chromium.org. ...
4 years, 10 months ago (2016-01-28 17:55:02 UTC) #11
Michael Achenbach
4 years, 10 months ago (2016-01-28 18:47:21 UTC) #12
Message was sent while issue was closed.
On 2016/01/28 17:55:02, joedow wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1645123002/ by mailto:joedow@chromium.org.
> 
> The reason for reverting is: Possibly causing compile failure on main chrome
> waterfall.  Reverting....

Looks like it wasn't the roll. Would have been hard to believe given the v8
changelist. Please reland this once you figured it out.

Powered by Google App Engine
This is Rietveld 408576698