Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1648603002:
Oilpan: Clear a resource when HTMLImportLoader::dispose is called (Closed)
|
Created:
4 years, 10 months ago by haraken Modified:
4 years, 10 months ago CC:
chromium-reviews, blink-reviews, tfarina, dglazkov+blink, blink-reviews-html_chromium.org, webcomponents-bugzilla_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionOilpan: Clear a resource when HTMLImportLoader::dispose is called
Otherwise, HTMLImportLoader::startWritingAndParsing can be called after the HTMLImportLoader is disposed.
BUG=582006
Committed: https://crrev.com/bb231ac4b1fda30b2fa0b49faa538fda29844d81
Cr-Commit-Position: refs/heads/master@{#372099}
Patch Set 1 #
Total comments: 1
Patch Set 2 : #Messages
Total messages: 16 (7 generated)
haraken@chromium.org changed reviewers: + oilpan-reviews@chromium.org, sigbjornf@opera.com
PTAL
https://codereview.chromium.org/1648603002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp (right): https://codereview.chromium.org/1648603002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp:108: if (!m_controller) Hmm, I wonder if we need to call clearResource() in dispose() instead?
Description was changed from ========== Oilpan: Add a null check to HTMLImportLoader::startWritingAndParsing At the point when HTMLImportLoader finishes receiving a response, the HTMLImportLoader may have already been disposed and thus m_controller may be null. BUG=582006 ========== to ========== Oilpan: Clear a resource when HTMLImportLoader::dispose is called Otherwise, HTMLImportLoader::startWritingAndParsing can be called after the HTMLImportLoader is disposed. BUG=582006 ==========
On 2016/01/28 09:35:17, sof wrote: > https://codereview.chromium.org/1648603002/diff/1/third_party/WebKit/Source/c... > File third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp (right): > > https://codereview.chromium.org/1648603002/diff/1/third_party/WebKit/Source/c... > third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp:108: if > (!m_controller) > Hmm, I wonder if we need to call clearResource() in dispose() instead? Good point. Done.
lgtm
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648603002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648603002/20001
Message was sent while issue was closed.
Description was changed from ========== Oilpan: Clear a resource when HTMLImportLoader::dispose is called Otherwise, HTMLImportLoader::startWritingAndParsing can be called after the HTMLImportLoader is disposed. BUG=582006 ========== to ========== Oilpan: Clear a resource when HTMLImportLoader::dispose is called Otherwise, HTMLImportLoader::startWritingAndParsing can be called after the HTMLImportLoader is disposed. BUG=582006 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Oilpan: Clear a resource when HTMLImportLoader::dispose is called Otherwise, HTMLImportLoader::startWritingAndParsing can be called after the HTMLImportLoader is disposed. BUG=582006 ========== to ========== Oilpan: Clear a resource when HTMLImportLoader::dispose is called Otherwise, HTMLImportLoader::startWritingAndParsing can be called after the HTMLImportLoader is disposed. BUG=582006 Committed: https://crrev.com/bb231ac4b1fda30b2fa0b49faa538fda29844d81 Cr-Commit-Position: refs/heads/master@{#372099} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/bb231ac4b1fda30b2fa0b49faa538fda29844d81 Cr-Commit-Position: refs/heads/master@{#372099} |
