Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1648593002: Revert of Add deprecation message for -webkit-background-composite (Closed)

Created:
4 years, 10 months ago by Noel Gordon
Modified:
4 years, 10 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add deprecation message for -webkit-background-composite (patchset #11 id:200001 of https://codereview.chromium.org/1585383003/ ) Reason for revert: Broke fast/backgrounds/webkit-background-composite-deprecated.html most bots. Example: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6/builds/48981 Original issue's description: > Add deprecation message for -webkit-background-composite > > This patch is two fold: > 1. Adds the capability of adding deprecation messages for CSSPropertyIDs > as they are parsed. > 2. Adds the relevant deprecation message for > -webkit-background-composite. The reasons for which are highlighted here > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/thxrbc8XOmc > > BUG=498588 > > Committed: https://crrev.com/6d2d7c3b60d3e5cd9b2efd7120cae737ad1e4329 > Cr-Commit-Position: refs/heads/master@{#372040} TBR=alancutter@chromium.org,timloh@chromium.org,nainar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=498588 Committed: https://crrev.com/674958fa7f06991f883e6ede28f25bb0ae8cd74b Cr-Commit-Position: refs/heads/master@{#372050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -140 lines) Patch
M third_party/WebKit/LayoutTests/fast/backgrounds/bgCompositeCopy-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/backgrounds/composite-highlight-is-invalid-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/fast/backgrounds/webkit-background-composite-deprecated.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/backgrounds/webkit-background-composite-deprecated-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 2 chunks +1 line, -5 lines 0 comments Download
D third_party/WebKit/Source/core/frame/Deprecation.h View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Noel Gordon
Created Revert of Add deprecation message for -webkit-background-composite
4 years, 10 months ago (2016-01-28 08:55:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648593002/1
4 years, 10 months ago (2016-01-28 08:55:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 08:57:07 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 08:58:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/674958fa7f06991f883e6ede28f25bb0ae8cd74b
Cr-Commit-Position: refs/heads/master@{#372050}

Powered by Google App Engine
This is Rietveld 408576698