Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: third_party/WebKit/Source/core/layout/line/InlineFlowBox.h

Issue 1648573002: Transition to explicit constructors in LayoutUnit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moar tweaks! Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
diff --git a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
index e03f8aab461eca36b77ae61deac4b99fa24ffa40..b2564cbf49d73ecfc7b81fda68e33bb4b4d4ac5d 100644
--- a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
+++ b/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
@@ -130,37 +130,37 @@ public:
LayoutUnit marginLogicalLeft() const
{
if (!includeLogicalLeftEdge())
- return 0;
+ return LayoutUnit();
return isHorizontal() ? boxModelObject().marginLeft() : boxModelObject().marginTop();
}
LayoutUnit marginLogicalRight() const
{
if (!includeLogicalRightEdge())
- return 0;
+ return LayoutUnit();
return isHorizontal() ? boxModelObject().marginRight() : boxModelObject().marginBottom();
}
int borderLogicalLeft() const
{
if (!includeLogicalLeftEdge())
- return 0;
+ return LayoutUnit();
eae 2016/01/29 03:38:12 return 0; (this method returns an int)
return isHorizontal() ? lineLayoutItem().style(isFirstLineStyle())->borderLeftWidth() : lineLayoutItem().style(isFirstLineStyle())->borderTopWidth();
}
int borderLogicalRight() const
{
if (!includeLogicalRightEdge())
- return 0;
+ return LayoutUnit();
eae 2016/01/29 03:38:12 return 0; (this method returns an int)
return isHorizontal() ? lineLayoutItem().style(isFirstLineStyle())->borderRightWidth() : lineLayoutItem().style(isFirstLineStyle())->borderBottomWidth();
}
int paddingLogicalLeft() const
{
if (!includeLogicalLeftEdge())
- return 0;
+ return LayoutUnit();
eae 2016/01/29 03:38:12 return 0; (this method returns an int)
return isHorizontal() ? boxModelObject().paddingLeft() : boxModelObject().paddingTop();
}
int paddingLogicalRight() const
{
if (!includeLogicalRightEdge())
- return 0;
+ return LayoutUnit();
eae 2016/01/29 03:38:12 return 0; (this method returns an int)
return isHorizontal() ? boxModelObject().paddingRight() : boxModelObject().paddingBottom();
}

Powered by Google App Engine
This is Rietveld 408576698