third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h - Issue 1648573002: Transition to explicit constructors in LayoutUnit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

Issue 1648573002: Transition to explicit constructors in LayoutUnit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moar tweaks! Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBlockFlow.h ('K') | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

index bf6aace83d6c02d6d0e361c36ba41e5f74df2be6..5ba4d99b5d7b66a8d4e71b05c309c798ae54260b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

@@ -218,7 +218,7 @@ public:

int borderHeight() const { return borderTop() + borderBottom(); }

// Insets from the border box to the inside of the border.

- LayoutRectOutsets borderInsets() const { return LayoutRectOutsets(-borderTop(), -borderRight(), -borderBottom(), -borderLeft()); }

+ LayoutRectOutsets borderInsets() const { return LayoutRectOutsets(LayoutUnit(-borderTop()), LayoutUnit(-borderRight()), LayoutUnit(-borderBottom()), LayoutUnit(-borderLeft())); }

eae 2016/01/29 03:38:12 How about adding a LayoutRectOutset constructor th

leviw_travelin_and_unemployed 2016/01/29 03:47:27 Sure.

bool hasBorderOrPadding() const { return style()->hasBorder() || style()->hasPadding(); }

@@ -234,7 +234,7 @@ public:

LayoutUnit borderAndPaddingLogicalWidth() const { return borderStart() + borderEnd() + paddingStart() + paddingEnd(); }

LayoutUnit borderAndPaddingLogicalLeft() const { return style()->isHorizontalWritingMode() ? borderLeft() + paddingLeft() : borderTop() + paddingTop(); }

- LayoutUnit borderLogicalLeft() const { return style()->isHorizontalWritingMode() ? borderLeft() : borderTop(); }

+ LayoutUnit borderLogicalLeft() const { return LayoutUnit(style()->isHorizontalWritingMode() ? borderLeft() : borderTop()); }

LayoutUnit paddingLogicalWidth() const { return paddingStart() + paddingEnd(); }

LayoutUnit paddingLogicalHeight() const { return paddingBefore() + paddingAfter(); }