Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 1648573002: Transition to explicit constructors in LayoutUnit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moar tweaks! Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
index 358c9b1ae37eaa29b6eab16bc94b8caa69b7b1c1..a8d1a620e30135ef6fc222ff10da1654425e4416 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
@@ -1274,9 +1274,9 @@ static inline LayoutPoint absoluteLineDirectionPointToLocalPointInBlock(RootInli
absoluteBlockPoint -= FloatSize(containingBlock.scrolledContentOffset());
if (root->block().isHorizontalWritingMode())
- return LayoutPoint(lineDirectionPoint - absoluteBlockPoint.x(), root->blockDirectionPointInLine());
+ return LayoutPoint(LayoutUnit(lineDirectionPoint - absoluteBlockPoint.x()), root->blockDirectionPointInLine());
eae 2016/01/29 03:38:11 lineDirectionPoint - LayoutUnit(absoluteBlockPoint
leviw_travelin_and_unemployed 2016/01/29 03:47:27 This is actually different behavior, and likely ch
- return LayoutPoint(root->blockDirectionPointInLine(), lineDirectionPoint - absoluteBlockPoint.y());
+ return LayoutPoint(root->blockDirectionPointInLine(), LayoutUnit(lineDirectionPoint - absoluteBlockPoint.y()));
eae 2016/01/29 03:38:11 ...and here: return LayoutPoint(root->blockDirect
leviw_travelin_and_unemployed 2016/01/29 03:47:27 Ditto.
}
VisiblePosition previousLinePosition(const VisiblePosition& visiblePosition, LayoutUnit lineDirectionPoint, EditableType editableType)

Powered by Google App Engine
This is Rietveld 408576698