third_party/WebKit/Source/platform/geometry/LayoutRect.cpp - Issue 1648573002: Transition to explicit constructors in LayoutUnit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/geometry/LayoutRect.cpp

Issue 1648573002: Transition to explicit constructors in LayoutUnit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove int constructors for size/point... they result in incorrect conversions until LayoutUnit is … Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/geometry/LayoutRect.cpp

diff --git a/third_party/WebKit/Source/platform/geometry/LayoutRect.cpp b/third_party/WebKit/Source/platform/geometry/LayoutRect.cpp

index f0714d77767a302d34bb5c1ded4c13c6a80f0222..ed331fb62e627cd4f5de0a5b0e8c33df31aeebc4 100644

--- a/third_party/WebKit/Source/platform/geometry/LayoutRect.cpp

+++ b/third_party/WebKit/Source/platform/geometry/LayoutRect.cpp

@@ -71,8 +71,8 @@ void LayoutRect::intersect(const LayoutRect& other)

// Return a clean empty rectangle for non-intersecting cases.

if (newLocation.x() >= newMaxPoint.x() || newLocation.y() >= newMaxPoint.y()) {

- newLocation = LayoutPoint(0, 0);

- newMaxPoint = LayoutPoint(0, 0);

+ newLocation = LayoutPoint();

+ newMaxPoint = LayoutPoint();

}

m_location = newLocation;