third_party/WebKit/Source/platform/geometry/LayoutPoint.h - Issue 1648573002: Transition to explicit constructors in LayoutUnit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/geometry/LayoutPoint.h

Issue 1648573002: Transition to explicit constructors in LayoutUnit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove int constructors for size/point... they result in incorrect conversions until LayoutUnit is … Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/geometry/LayoutPoint.h

diff --git a/third_party/WebKit/Source/platform/geometry/LayoutPoint.h b/third_party/WebKit/Source/platform/geometry/LayoutPoint.h

index b1fcf37d4639c1ab9757850e820751be66f446a4..b61956b3e0c902dbb383f3f465e363cb72f0b1bf 100644

--- a/third_party/WebKit/Source/platform/geometry/LayoutPoint.h

+++ b/third_party/WebKit/Source/platform/geometry/LayoutPoint.h

@@ -61,6 +61,7 @@ public:

void move(const LayoutSize& s) { move(s.width(), s.height()); }

void move(const IntSize& s) { move(s.width(), s.height()); }

void moveBy(const LayoutPoint& offset) { move(offset.x(), offset.y()); }

+ void move(int dx, int dy) { move(LayoutUnit(dx), LayoutUnit(dy)); }

void move(LayoutUnit dx, LayoutUnit dy) { m_x += dx; m_y += dy; }

void scale(float sx, float sy)

{