third_party/WebKit/Source/core/style/NinePieceImage.h - Issue 1648573002: Transition to explicit constructors in LayoutUnit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/NinePieceImage.h

Issue 1648573002: Transition to explicit constructors in LayoutUnit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove int constructors for size/point... they result in incorrect conversions until LayoutUnit is … Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/NinePieceImage.h

diff --git a/third_party/WebKit/Source/core/style/NinePieceImage.h b/third_party/WebKit/Source/core/style/NinePieceImage.h

index 8c1a50e2c305c3d398c506f47a2feb63ff5fa42b..9401f019667d3be1689c24b4b983bf4c04d2c2d4 100644

--- a/third_party/WebKit/Source/core/style/NinePieceImage.h

+++ b/third_party/WebKit/Source/core/style/NinePieceImage.h

@@ -123,8 +123,8 @@ public:

static LayoutUnit computeOutset(const BorderImageLength& outsetSide, LayoutUnit borderSide)

{

if (outsetSide.isNumber())

- return outsetSide.number() * borderSide;

- return outsetSide.length().value();

+ return LayoutUnit(outsetSide.number() * borderSide);

+ return LayoutUnit(outsetSide.length().value());

}

private: