third_party/WebKit/Source/core/layout/LayoutListMarker.cpp - Issue 1648573002: Transition to explicit constructors in LayoutUnit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

Issue 1648573002: Transition to explicit constructors in LayoutUnit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove int constructors for size/point... they result in incorrect conversions until LayoutUnit is … Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp b/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

index d5b22f997b5ff35f4c96a8094c20a2aeb9039379..1d105b678912e10a6172bd3f108872ce7ecac732 100644

--- a/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

@@ -119,8 +119,8 @@ LayoutRect LayoutListMarker::localSelectionRect() const

? inlineBoxWrapper()->logicalBottom() - root.selectionBottom()

: root.selectionTop() - inlineBoxWrapper()->logicalTop();

return blockStyle->isHorizontalWritingMode()

- ? LayoutRect(0, newLogicalTop, size().width(), root.selectionHeight())

- : LayoutRect(newLogicalTop, 0, root.selectionHeight(), size().height());

+ ? LayoutRect(LayoutUnit(), newLogicalTop, size().width(), root.selectionHeight())

+ : LayoutRect(newLogicalTop, LayoutUnit(), root.selectionHeight(), size().height());

}

void LayoutListMarker::paint(const PaintInfo& paintInfo, const LayoutPoint& paintOffset) const