[mojo] Get rid of Skia type converters

ui/gfx/ipc/gfx_param_traits.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/ipc/gfx_param_traits.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <string>
@@ skipping 238 matching lines @@
   const float* values = reinterpret_cast<const float*>(char_values);
   r->SetRect(values[0], values[1], values[2], values[3]);
   return true;
 }
 
 void ParamTraits<gfx::RectF>::Log(const gfx::RectF& p, std::string* l) {
   l->append(base::StringPrintf("(%f, %f, %f, %f)", p.x(), p.y(),
                                p.width(), p.height()));
 }
 
-void ParamTraits<SkBitmap>::Write(Message* m, const SkBitmap& p) {
+size_t ParamTraits<SkBitmap>::GetSize(const SkBitmap& p) {

[Ken Rockot(use gerrit already), 2016/02/01 17:57:01]

NOTE to tsepez@: Defining a GetSize() trait is a prerequisite for using a
ParamTraits<T> as a serializer on top of Mojo, because we always preallocate
buffers for Mojo messages. I was thinking it might reduce errors to add a
base::PickleSizer type with an interface analogous to base::Pickle but which
just computes payload size, then we could pass that to GetSize instead of asking
developers to compute it 100% manually.

Alternatively we could make Pickle's interfaces virtual, have a new Pickle impl
just for computing size, and feed that directly to ParamTraits<T>::Write for a
first pass. I've been avoiding that approach because I didn't want to add vtable
lookups to such frequently called methods.

WDYT?

[Tom Sepez, 2016/02/01 18:31:58]

I prefer the first approach, I wouldn't be fond of adding virtual calls to
pickle.

+  return sizeof(int32_t) * 2 + sizeof(SkBitmap_Data) + p.getSize();

[jam, 2016/02/01 17:53:48]

I'd expect this to match the Write method below, why the difference?

i.e. the "sizeof(SkBitmap_Data) + p.getSize();" parts correspond to the two
WriteData calls, but where is the "sizeof(int32_t)" calls coming from?

+}
+
+void ParamTraits<SkBitmap>::Write(base::Pickle* m, const SkBitmap& p) {
   size_t fixed_size = sizeof(SkBitmap_Data);
   SkBitmap_Data bmp_data;
   bmp_data.InitSkBitmapDataForTransfer(p);
   m->WriteData(reinterpret_cast<const char*>(&bmp_data),
                static_cast<int>(fixed_size));
   size_t pixel_size = p.getSize();
   SkAutoLockPixels p_lock(p);
   m->WriteData(reinterpret_cast<const char*>(p.getPixels()),
                static_cast<int>(pixel_size));
 }
 
-bool ParamTraits<SkBitmap>::Read(const Message* m,
+bool ParamTraits<SkBitmap>::Read(const base::Pickle* m,
                                  base::PickleIterator* iter,
                                  SkBitmap* r) {
   const char* fixed_data;
   int fixed_data_size = 0;
   if (!iter->ReadData(&fixed_data, &fixed_data_size) ||
      (fixed_data_size <= 0)) {
     NOTREACHED();
     return false;
   }
   if (fixed_data_size != sizeof(SkBitmap_Data))
@@ skipping 104 matching lines @@
 #undef UI_GFX_IPC_GFX_PARAM_TRAITS_MACROS_H_
 #include "ui/gfx/ipc/gfx_param_traits_macros.h"
 }  // namespace IPC
 
 // Generate param traits log methods.
 #include "ipc/param_traits_log_macros.h"
 namespace IPC {
 #undef UI_GFX_IPC_GFX_PARAM_TRAITS_MACROS_H_
 #include "ui/gfx/ipc/gfx_param_traits_macros.h"
 }  // namespace IPC