Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1648523002: DevTools: move InjectedScript* to inspector/v8. (Closed)

Created:
4 years, 11 months ago by pfeldman
Modified:
4 years, 10 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-api_chromium.org, blink-reviews-bindings_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, Eric Willigers, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, rjwright, sergeyv+blink_chromium.org, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: move InjectedScript* to inspector/v8. BUG=580337 NOPRESUBMIT=true Committed: https://crrev.com/0f7fedde5038168d09d51734d798b6e288e23376 Cr-Commit-Position: refs/heads/master@{#372093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -4216 lines) Patch
D third_party/WebKit/Source/bindings/core/v8/ScriptFunctionCall.h View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/ScriptFunctionCall.cpp View 1 chunk +0 lines, -131 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/v8.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 3 chunks +10 lines, -8 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/DebuggerScript.js View 1 chunk +0 lines, -617 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/InjectedScript.h View 1 chunk +0 lines, -136 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/InjectedScript.cpp View 1 chunk +0 lines, -539 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/InjectedScriptHost.h View 1 chunk +0 lines, -118 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/InjectedScriptHost.cpp View 1 chunk +0 lines, -138 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/InjectedScriptHostClient.h View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/InjectedScriptManager.h View 1 chunk +0 lines, -81 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/InjectedScriptManager.cpp View 1 chunk +0 lines, -188 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/InjectedScriptNative.h View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/InjectedScriptNative.cpp View 1 chunk +0 lines, -101 lines 0 comments Download
D third_party/WebKit/Source/core/inspector/InjectedScriptSource.js View 1 chunk +0 lines, -1935 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageDebuggerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerDebuggerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerRuntimeAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/DebuggerScript.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/InjectedScript.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/InjectedScript.cpp View 22 chunks +26 lines, -26 lines 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/InjectedScriptHost.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/InjectedScriptHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/InjectedScriptHostClient.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/InjectedScriptManager.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/InjectedScriptManager.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/InjectedScriptNative.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/InjectedScriptNative.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/InjectedScriptSource.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/V8FunctionCall.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/core/inspector/v8/V8FunctionCall.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/compile_frontend.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/blink_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
pfeldman
4 years, 11 months ago (2016-01-28 00:33:57 UTC) #2
haraken
bindings LGTM
4 years, 11 months ago (2016-01-28 00:35:25 UTC) #3
dgozman
lgtm
4 years, 11 months ago (2016-01-28 01:09:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648523002/1
4 years, 10 months ago (2016-01-28 06:26:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/139963)
4 years, 10 months ago (2016-01-28 06:35:59 UTC) #8
jochen (gone - plz use gerrit)
you'll have to use NOPRESUBMIT=true
4 years, 10 months ago (2016-01-28 12:15:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648523002/1
4 years, 10 months ago (2016-01-28 15:03:30 UTC) #13
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/inspector/v8/InjectedScriptManager.cpp: While running git apply --index -3 -p1; error: patch ...
4 years, 10 months ago (2016-01-28 15:05:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648523002/1
4 years, 10 months ago (2016-01-28 15:49:35 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 15:51:16 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 15:52:06 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f7fedde5038168d09d51734d798b6e288e23376
Cr-Commit-Position: refs/heads/master@{#372093}

Powered by Google App Engine
This is Rietveld 408576698