Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1648513002: [DevTools] use sourceMapURL and sourceRoot in SourceMap parser on backend (Closed)

Created:
4 years, 11 months ago by kozy
Modified:
4 years, 11 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] use sourceMapURL and sourceRoot in SourceMap parser on backend BUG=341082 R=dgozman@chromium.org Committed: https://crrev.com/7e07be5255a53fa7d62c0b937e9f5cbd210111f5 Cr-Commit-Position: refs/heads/master@{#371982}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added link to spec #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -74 lines) Patch
M third_party/WebKit/Source/core/inspector/v8/SourceMap.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp View 1 8 chunks +25 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/SourceMapTest.cpp View 6 chunks +64 lines, -64 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
kozy
Dmitry, please take a look.
4 years, 11 months ago (2016-01-28 00:13:31 UTC) #1
pfeldman
https://codereview.chromium.org/1648513002/diff/1/third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp File third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp (right): https://codereview.chromium.org/1648513002/diff/1/third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp#newcode207 third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:207: if (!sourceRoot.isNull() && sourceRoot.length() > 0 && sourceRoot[sourceRoot.length() - ...
4 years, 11 months ago (2016-01-28 01:13:49 UTC) #3
kozy
All done. https://codereview.chromium.org/1648513002/diff/1/third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp File third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp (right): https://codereview.chromium.org/1648513002/diff/1/third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp#newcode207 third_party/WebKit/Source/core/inspector/v8/SourceMap.cpp:207: if (!sourceRoot.isNull() && sourceRoot.length() > 0 && ...
4 years, 11 months ago (2016-01-28 01:31:09 UTC) #4
pfeldman
lgtm
4 years, 11 months ago (2016-01-28 01:33:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648513002/20001
4 years, 11 months ago (2016-01-28 01:37:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-28 03:10:50 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-28 03:12:37 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7e07be5255a53fa7d62c0b937e9f5cbd210111f5
Cr-Commit-Position: refs/heads/master@{#371982}

Powered by Google App Engine
This is Rietveld 408576698