Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1648503003: [wasm] Fix CallIndirect with the case of no indirect function table. (Closed)

Created:
4 years, 10 months ago by titzer
Modified:
4 years, 10 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix CallIndirect with the case of no indirect function table. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Committed: https://crrev.com/3668b2c0b3aec3fabf62f5633b6e807608eb6264 Cr-Commit-Position: refs/heads/master@{#33592}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -26 lines) Patch
M src/compiler/wasm-compiler.cc View 4 chunks +34 lines, -25 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 10 months ago (2016-01-28 13:26:03 UTC) #1
ahaas
lgtm
4 years, 10 months ago (2016-01-28 16:47:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648503003/1
4 years, 10 months ago (2016-01-28 16:48:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-28 16:57:00 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 16:57:47 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3668b2c0b3aec3fabf62f5633b6e807608eb6264
Cr-Commit-Position: refs/heads/master@{#33592}

Powered by Google App Engine
This is Rietveld 408576698