Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issue 1648503002: Make content_gpu.gypi depend on content_common_mojo_bindings in gyp. (Closed)

Created:
4 years, 11 months ago by jbudorick
Modified:
4 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make content_gpu.gypi depend on content_common_mojo_bindings in gyp. mirroring https://code.google.com/p/chromium/codesearch#chromium/src/content/gpu/BUILD.gn&l=53 BUG=581707 NOTRY=true NOTREECHECKS=true TBR=jam@chromium.org Committed: https://crrev.com/12556951e56fb712f8fab1ec24eb73447a448f19 Cr-Commit-Position: refs/heads/master@{#371910}

Patch Set 1 #

Patch Set 2 : reorder to be consistent with other content*.gypis #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/content_gpu.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
jbudorick
NOTRY + NOTREECHECKS to fix ToT
4 years, 11 months ago (2016-01-27 23:33:03 UTC) #2
jbudorick
+jam for owners
4 years, 11 months ago (2016-01-27 23:33:30 UTC) #4
Dmitry Skiba
lgtm
4 years, 11 months ago (2016-01-27 23:39:44 UTC) #5
jbudorick
TBR: fixing broken tree
4 years, 11 months ago (2016-01-27 23:44:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1648503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1648503002/20001
4 years, 11 months ago (2016-01-27 23:46:34 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-27 23:54:27 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 23:55:53 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/12556951e56fb712f8fab1ec24eb73447a448f19
Cr-Commit-Position: refs/heads/master@{#371910}

Powered by Google App Engine
This is Rietveld 408576698