Rely less on DisplayInfo in display_options.js

Rely less on DisplayInfo in display_options.js

For extended desktop (non mirrored) layouts, |displays_| should only
provide input parameters to the UI. Iteration over display layouts
should occur in DisplayLayoutManager. This is necessary to support
fake display layouts for testing (and provides a cleaner abstraction
in general).

This also fixes a couple of bugs related to changing the number of displays introduced in other recent re-factoring.

BUG=576375
Committed: https://crrev.com/bbfe0d4e936fdc6277b733e33aa1aa7e8411b760
Cr-Commit-Position: refs/heads/master@{#371968}

[stevenjb, 2016-01-27 23:04:31]

Description was changed from

==========
Rely less on displays_ in display_options.js

For extended desktop (non mirrored) layouts, |displays_| should only
provide input parameters to the UI. Iteration over display layouts
should occur in DisplayLayoutManager. This is necessary to support
fake display layout info for testing.

BUG=576375
==========

to

==========
Rely less on DisplayInfo in display_options.js

For extended desktop (non mirrored) layouts, |displays_| should only
provide input parameters to the UI. Iteration over display layouts
should occur in DisplayLayoutManager. This is necessary to support
fake display layouts for testing (and provides a cleaner abstraction
in genral).

BUG=576375
==========

[stevenjb, 2016-01-27 23:12:37]

Description was changed from

==========
Rely less on DisplayInfo in display_options.js

For extended desktop (non mirrored) layouts, |displays_| should only
provide input parameters to the UI. Iteration over display layouts
should occur in DisplayLayoutManager. This is necessary to support
fake display layouts for testing (and provides a cleaner abstraction
in genral).

BUG=576375
==========

to

==========
Rely less on DisplayInfo in display_options.js

For extended desktop (non mirrored) layouts, |displays_| should only
provide input parameters to the UI. Iteration over display layouts
should occur in DisplayLayoutManager. This is necessary to support
fake display layouts for testing (and provides a cleaner abstraction
in general).

This also fixes a couple of bugs related to changing the number of displays
introduced in other recent re-factoring.

BUG=576375
==========

[stevenjb, 2016-01-27 23:13:35]

stevenjb@chromium.org changed reviewers:
+ xiyuan@chromium.org

[xiyuan, 2016-01-28 00:13:36]

lgtm

https://codereview.chromium.org/1648493002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/options/chromeos/display_layout_manager.js
(right):

https://codereview.chromium.org/1648493002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/display_layout_manager.js:3: */
remove?

https://codereview.chromium.org/1648493002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/display_layout_manager.js:177:
(div.offsetParent && layout.div == div.offsetParent)) {
I wonder whether we need to recursively crawl up the Dom tree, in case we have
more stuff put in the display div. findAncestor in utils.js [1] might be useful
if we need to do that.

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources...

[stevenjb, 2016-01-28 01:01:23]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-01-28 01:01:23]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1648493002/#ps40001
(title: "Feedback")

[commit-bot: I haz the power, 2016-01-28 01:04:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1648493002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1648493002/40001

[commit-bot: I haz the power, 2016-01-28 02:23:38]

Description was changed from

==========
Rely less on DisplayInfo in display_options.js

For extended desktop (non mirrored) layouts, |displays_| should only
provide input parameters to the UI. Iteration over display layouts
should occur in DisplayLayoutManager. This is necessary to support
fake display layouts for testing (and provides a cleaner abstraction
in general).

This also fixes a couple of bugs related to changing the number of displays
introduced in other recent re-factoring.

BUG=576375
==========

to

==========
Rely less on DisplayInfo in display_options.js

For extended desktop (non mirrored) layouts, |displays_| should only
provide input parameters to the UI. Iteration over display layouts
should occur in DisplayLayoutManager. This is necessary to support
fake display layouts for testing (and provides a cleaner abstraction
in general).

This also fixes a couple of bugs related to changing the number of displays
introduced in other recent re-factoring.

BUG=576375
==========

[commit-bot: I haz the power, 2016-01-28 02:23:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-28 02:24:39]

Description was changed from

==========
Rely less on DisplayInfo in display_options.js

For extended desktop (non mirrored) layouts, |displays_| should only
provide input parameters to the UI. Iteration over display layouts
should occur in DisplayLayoutManager. This is necessary to support
fake display layouts for testing (and provides a cleaner abstraction
in general).

This also fixes a couple of bugs related to changing the number of displays
introduced in other recent re-factoring.

BUG=576375
==========

to

==========
Rely less on DisplayInfo in display_options.js

For extended desktop (non mirrored) layouts, |displays_| should only
provide input parameters to the UI. Iteration over display layouts
should occur in DisplayLayoutManager. This is necessary to support
fake display layouts for testing (and provides a cleaner abstraction
in general).

This also fixes a couple of bugs related to changing the number of displays
introduced in other recent re-factoring.

BUG=576375

Committed: https://crrev.com/bbfe0d4e936fdc6277b733e33aa1aa7e8411b760
Cr-Commit-Position: refs/heads/master@{#371968}
==========

[commit-bot: I haz the power, 2016-01-28 02:24:45]

Patchset 3 (id:??) landed as
https://crrev.com/bbfe0d4e936fdc6277b733e33aa1aa7e8411b760
Cr-Commit-Position: refs/heads/master@{#371968}

[stevenjb, 2016-01-28 19:58:42]

https://codereview.chromium.org/1648493002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/options/chromeos/display_layout_manager.js
(right):

https://codereview.chromium.org/1648493002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/display_layout_manager.js:3: */
On 2016/01/28 00:13:35, xiyuan wrote:
> remove?

Something in my editor likes to add this but I haven't been able to figure out
when/why it's happening, argh. Removed.

https://codereview.chromium.org/1648493002/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/chromeos/display_layout_manager.js:177:
(div.offsetParent && layout.div == div.offsetParent)) {
On 2016/01/28 00:13:35, xiyuan wrote:
> I wonder whether we need to recursively crawl up the Dom tree, in case we have
> more stuff put in the display div. findAncestor in utils.js [1] might be
useful
> if we need to do that.
> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources...

Noted for the new implementation. For this one, I'll keep it as-is for now.