third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js - Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

index b7110f3676e5793f00bc0a74450866dbc2a604af..970bbd44db6c4319e0f170ef51cd79e34caad207 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

@@ -317,6 +317,7 @@ WebInspector.ExecutionContext.prototype = {

function evalCallback(error, result, wasThrown, exceptionDetails)

{

if (error) {

+ console.error(error);

callback(null, false);

return;

}

« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp ('k') | no next file » | no next file with comments »