third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp - Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/MainThreadDebugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

index b7b616fef49f6dcde11be017f3672db710d3b23f..3cd1834b265f9efd13c777a7a135742883e83e9c 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

@@ -366,7 +366,8 @@ void InspectorHeapProfilerAgent::getHeapObjectId(ErrorString* errorString, const

*errorString = "Inspected context has gone";

return;

}

- ScriptState::Scope scope(injectedScript->scriptState());

+ v8::HandleScope handles(injectedScript->isolate());

v8::Local<v8::Value> value = injectedScript->findObject(*remoteId);

if (value.IsEmpty() || value->IsUndefined()) {

*errorString = "Object with given id not found";