third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp - Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

index abd3cc840b1245a157859e1b576f9976ab1209bb..2503d4931983135518fd2bd0c499527c800bd863 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

@@ -1220,13 +1220,13 @@ Node* InspectorDOMAgent::nodeForRemoteId(ErrorString* errorString, const String&

*errorString = "Cannot find context for specified object id";

return nullptr;

}

- ScriptState::Scope scope(injectedScript->scriptState());

+ v8::HandleScope handles(injectedScript->isolate());

v8::Local<v8::Value> value = injectedScript->findObject(*remoteId);

if (value.IsEmpty()) {

*errorString = "Node for given objectId not found";

return nullptr;

}

- v8::Isolate* isolate = injectedScript->scriptState()->isolate();

+ v8::Isolate* isolate = injectedScript->isolate();

if (!V8Node::hasInstance(value, isolate)) {

*errorString = "Object id doesn't reference a Node";

return nullptr;