third_party/WebKit/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp - Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

Issue 1648463002: DevTools: migrate injectedscript from ScriptValue to v8::Global. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

index 31a6795fb46b9387cfb17264eef5a084e70471e6..3e3d2bcdc5635f8ce4f73e2ea4519bad7c71672f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp

@@ -30,7 +30,6 @@

#include "core/inspector/InjectedScriptManager.h"

-#include "bindings/core/v8/ScriptValue.h"

#include "bindings/core/v8/V8Binding.h"

#include "bindings/core/v8/V8ScriptRunner.h"

#include "core/inspector/InjectedScriptHost.h"

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InjectedScript.h » ('j') | no next file with comments »